srowen commented on a change in pull request #27099: [SPARK-30335][SQL][DOCS]
Add a note first and last can be non-deterministic in SQL function docs as well
URL: https://github.com/apache/spark/pull/27099#discussion_r363324302
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -549,7 +549,7 @@ object functions {
* The function by default returns the last values it sees. It will return
the last non-null
* value it sees when ignoreNulls is set to true. If all values are null,
then null is returned.
*
- * @note The function is non-deterministic because its results depends on
order of rows which
+ * @note The function is non-deterministic because its results depends on
the order of rows which
Review comment:
Total nit, but you use "on the order or rows" here but "on order of the
rows" above. The most correct would be 'the order of the rows' but honestly
doesn't matter much. Feel free to standardize on anything
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
