cloud-fan commented on a change in pull request #26933: [SPARK-30292][SQL]Throw
Exception when invalid string is cast to numeric type in ANSI mode
URL: https://github.com/apache/spark/pull/26933#discussion_r363356669
##########
File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/float8.sql
##########
@@ -45,15 +45,15 @@ SELECT double('infinity');
SELECT double(' -INFINiTY ');
-- [SPARK-27923] Spark SQL insert there bad special inputs to NULL
-- bad special inputs
-SELECT double('N A N');
-SELECT double('NaN x');
-SELECT double(' INFINITY x');
+-- SELECT double('N A N');
+-- SELECT double('NaN x');
+-- SELECT double(' INFINITY x');
Review comment:
looks like the answer file is wrong? I don't think postgres will return null
for these queries. Can we re-generate the answer files? You can refer to the
classdoc of `SQLQueryTestSuite`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
