dongjoon-hyun commented on a change in pull request #27110: [SPARK-30439][SQL] 
support NOT NULL in column data type
URL: https://github.com/apache/spark/pull/27110#discussion_r363415967
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
 ##########
 @@ -126,10 +126,6 @@ private[sql] object CatalogV2Util {
 
         case update: UpdateColumnType =>
           replace(schema, update.fieldNames, field => {
-            if (!update.isNullable && field.nullable) {
 
 Review comment:
   The UT failure seems related to this one. Could you fix the UT failure?
   > test("alterTable: update optional column to required fails")

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to