HyukjinKwon commented on a change in pull request #27089: [SPARK-30414][SQL]
ParquetRowConverter optimizations: arrays, maps, plus misc. constant factors
URL: https://github.com/apache/spark/pull/27089#discussion_r363551029
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
##########
@@ -614,12 +615,12 @@ private[parquet] class ParquetRowConverter(
}
private trait RepeatedConverter {
- private var currentArray: ArrayBuffer[Any] = _
+ private[this] val currentArray = new java.util.ArrayList[Any]()
Review comment:
@JoshRosen, sorry if I'm ignorant about this but why do we need to change
`ArrayBuffer` -> `ArrayList`? Seems `ArrayBuffer` itself is mutable and can
`clear()` too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
