cloud-fan commented on a change in pull request #27095: [SPARK-30214][SQL] V2 commands resolves namespaces with new resolution framework URL: https://github.com/apache/spark/pull/27095#discussion_r363582446
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala ########## @@ -362,37 +367,48 @@ case class ShowTableStatement( * A CREATE NAMESPACE statement, as parsed from SQL. */ case class CreateNamespaceStatement( - namespace: Seq[String], + namespace: LogicalPlan, Review comment: I'm not very sure about this. For `CREATE` commands, they only need to know the catalog, but no need to lookup table or namespace. I think we can keep using `Seq[String]` and still handle the commands in `ResolveCatalogs`/`ResolveSessionCatalogs`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
