cloud-fan commented on a change in pull request #26959: [SPARK-30315][SQL] Add
adaptive execution context
URL: https://github.com/apache/spark/pull/26959#discussion_r360323553
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -275,7 +275,7 @@ object QueryExecution {
Seq(
// `AdaptiveSparkPlanExec` is a leaf node. If inserted, all the
following rules will be no-op
// as the original plan is hidden behind `AdaptiveSparkPlanExec`.
- InsertAdaptiveSparkPlan(sparkSession),
+ InsertAdaptiveSparkPlan(AdaptiveExecutionContext(sparkSession)),
Review comment:
It seems clearer to me to create `AdaptiveExecutionContext` inside
`InsertAdaptiveSparkPlan` rule, and just pass `SparkSession` to the rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
