maropu commented on a change in pull request #27092: [SPARK-30416][SQL] Log a
warning for deprecated SQL config in `set()` and `unset()`
URL: https://github.com/apache/spark/pull/27092#discussion_r364018890
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
##########
@@ -330,4 +335,31 @@ class SQLConfSuite extends QueryTest with
SharedSparkSession {
}
assert(e.getMessage.contains(config))
}
+
+ test("log deprecation warnings") {
+ val logAppender = new AppenderSkeleton {
Review comment:
nit: The same class `logAppender` seems to be defined in some places below,
so can we define a helper method for this test purpose somewhere (e.g.,
`TestUtils`)?
```
$grep -nr "extends AppenderSkeleton" .
./catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveHintsSuite.scala:36:
class MockAppender extends AppenderSkeleton {
./catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala:525:
class MockAppender extends AppenderSkeleton {
./catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerLoggingSuite.scala:42:
class MockAppender extends AppenderSkeleton {
./core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala:1766:
class TestAppender extends AppenderSkeleton {
./core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala:41: class
MockAppender extends AppenderSkeleton {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
