Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4592#discussion_r24713035
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala 
---
    @@ -93,7 +93,14 @@ private[sql] class DataFrameImpl protected[sql](
           queryExecution.analyzed.resolve(n.name, 
sqlContext.analyzer.resolver).get
         }
       }
    -
    + 
    +  protected[sql] def numericColumns(colNames: String*): Seq[Expression] = {
    --- End diff --
    
    i don't think you'd want this. if an user explicitly specifies a column, we 
should just throw an error rather than silently dropping the column from 
numeric aggregation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to