advancedxy commented on a change in pull request #27100:
[SPARK-29037][CORE][SQL] Fix the issue that spark gives duplicate result and
support concurrent file source write operations write to different partitions
in the same table.
URL: https://github.com/apache/spark/pull/27100#discussion_r364048415
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
##########
@@ -106,103 +120,143 @@ case class InsertIntoHadoopFsRelationCommand(
fs, catalogTable.get, qualifiedOutputPath, matchingPartitions)
}
+ val parameters = CaseInsensitiveMap(options)
+
+ val partitionOverwriteMode = parameters.get("partitionOverwriteMode")
+ // scalastyle:off caselocale
+ .map(mode => PartitionOverwriteMode.withName(mode.toUpperCase))
Review comment:
Please don't turn off caselocale style check, just call
`mode.toUpperCase(Locale.ROOT)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
