HeartSaVioR commented on a change in pull request #26955: [SPARK-30310] [Core]
Resolve missing match case in SparkUncaughtExceptionHandler and added tests
URL: https://github.com/apache/spark/pull/26955#discussion_r364056277
##########
File path:
core/src/main/scala/org/apache/spark/util/SparkUncaughtExceptionHandler.scala
##########
@@ -48,11 +48,24 @@ private[spark] class SparkUncaughtExceptionHandler(val
exitOnUncaughtException:
System.exit(SparkExitCode.OOM)
case _ if exitOnUncaughtException =>
System.exit(SparkExitCode.UNCAUGHT_EXCEPTION)
+ case _ =>
+ // SPARK-30310: Don't System.exit() when exitOnUncaughtException
is false
}
}
} catch {
- case oom: OutOfMemoryError => Runtime.getRuntime.halt(SparkExitCode.OOM)
- case t: Throwable =>
Runtime.getRuntime.halt(SparkExitCode.UNCAUGHT_EXCEPTION_TWICE)
+ case oom: OutOfMemoryError =>
+ try { logError(s"Uncaught OutOfMemoryError in thread $thread, process
halted.", oom) }
Review comment:
Thanks for the update! It's a nit, but maybe better to be consistent on
style:
```
try {
...
} catch {
...
}
```
as one-liner of try statement and multi-lines or catch statement look
inconsistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
