HyukjinKwon commented on a change in pull request #24518: [SPARK-27627][SQL]
Make option "pathGlobFilter" as a general option for all file sources
URL: https://github.com/apache/spark/pull/24518#discussion_r364091620
##########
File path:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala
##########
@@ -59,14 +59,15 @@ class AvroOptions(
* If the option is not set, the Hadoop's config
`avro.mapred.ignore.inputs.without.extension`
* is taken into account. If the former one is not set too, file extensions
are ignored.
*/
+ @deprecated("Use the general data source option pathGlobFilter for filtering
file names", "3.0")
Review comment:
I think we should remove `deprecated`.
It would be great if we can put that logic into `AvroOptions` e.g.:
```scala
parameters
.get(AvroOptions.ignoreExtensionKey)
.map { v =>
logWarning(...)
v.toBoolean
}.getOrElse(!ignoreFilesWithoutExtension)
```
However, can you make it doesn't show the logs too many times? If we put
there, seems like it will show the same logs multiple times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
