Eric5553 commented on a change in pull request #26977: [SPARK-30326][SQL] Raise
exception if analyzer exceed max iterations
URL: https://github.com/apache/spark/pull/26977#discussion_r364095962
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala
##########
@@ -47,6 +47,19 @@ trait AnalysisTest extends PlanTest {
}
}
+ protected def makeAnalyzerWithConf(conf: SQLConf): Analyzer = {
Review comment:
@maropu The strategy field `fixedPoint` of Analyzer/Optimizer is determined
when analyzer/optimizer initialized, thus SQLConf will not affect their
behavior during runtime. `getAnalyzer()` only support makeAnalyzer with
CASE_SENSITIVE config, while I think adding more config such as
ANALYZER_MAX_ITERATIONS to `getAnalyzer()` will be too specific. That’s why I
introduced this helper method with SQLConf input parameter, which will also
support future test case requirements like ANALYZER_MAX_ITERATIONS does. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
