ajithme commented on a change in pull request #27116: [SPARK-30440][CORE][TEST]
Fix flaky test of SPARK-30359
URL: https://github.com/apache/spark/pull/27116#discussion_r364178100
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1919,7 +1919,12 @@ class TaskSetManagerSuite
TestUtils.waitUntilExecutorsUp(sc, 2, 60000)
val Seq(exec0, exec1) = backend.getExecutorIds()
- val taskSet = FakeTask.createTaskSet(2)
+ // SPARK-30440: it's possible that tasks have already been scheduled after
we call
+ // `sched.submitTasks(taskSet)` but before `manager.resourceOffer`. In
this case,
Review comment:
I don't understand how is mine a overkill when actually what should matter
is better approach for fix always. As i mentioned earlier, this PR duplicates
development and review effort for https://github.com/apache/spark/pull/27115
then why still insist here.?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
