guykhazma commented on a change in pull request #27112: [SPARK-30428][SQL] File
source V2: support partition pruning
URL: https://github.com/apache/spark/pull/27112#discussion_r364290260
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala
##########
@@ -39,31 +72,35 @@ private[sql] object PruneFileSourcePartitions extends
Rule[LogicalPlan] {
_,
_))
if filters.nonEmpty && fsRelation.partitionSchemaOption.isDefined =>
- val normalizedFilters = DataSourceStrategy.normalizeExprs(
- filters.filterNot(SubqueryExpression.hasSubquery),
logicalRelation.output)
-
- val sparkSession = fsRelation.sparkSession
- val partitionColumns =
- logicalRelation.resolve(
- partitionSchema, sparkSession.sessionState.analyzer.resolver)
- val partitionSet = AttributeSet(partitionColumns)
- val partitionKeyFilters = ExpressionSet(normalizedFilters.filter { f =>
- f.references.subsetOf(partitionSet)
- })
-
+ val partitionKeyFilters = getPartitionKeyFilters(
+ fsRelation.sparkSession, logicalRelation, partitionSchema, filters,
logicalRelation.output)
if (partitionKeyFilters.nonEmpty) {
val prunedFileIndex =
catalogFileIndex.filterPartitions(partitionKeyFilters.toSeq)
val prunedFsRelation =
- fsRelation.copy(location = prunedFileIndex)(sparkSession)
+ fsRelation.copy(location = prunedFileIndex)(fsRelation.sparkSession)
Review comment:
I suggest to pass also the `dataFilters`.
This is useful for FileIndex implementations that use the `dataFilters` to
do the file listing.
For example, we use this to provide data skipping for all file based
datasources.
I suggest something like this guykhazma@
de3415b80b92e635dbc0b331515a8cec4c5098d6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
