viirya commented on a change in pull request #27064:
[SPARK-30246]OneForOneStreamManager might leak memory in connectionTerminated
URL: https://github.com/apache/spark/pull/27064#discussion_r364520621
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
##########
@@ -117,19 +118,26 @@ public static String genStreamChunkId(long streamId, int
chunkId) {
@Override
public void connectionTerminated(Channel channel) {
+ LinkedList<StreamState> removedStates = new LinkedList<>();
// Close all streams which have been associated with the channel.
for (Map.Entry<Long, StreamState> entry: streams.entrySet()) {
StreamState state = entry.getValue();
if (state.associatedChannel == channel) {
- streams.remove(entry.getKey());
+ removedStates.add(streams.remove(entry.getKey()));
+ }
+ }
- // Release all remaining buffers.
+ for (StreamState state: removedStates) {
+ // Release all remaining buffers.
+ try {
while (state.buffers.hasNext()) {
ManagedBuffer buffer = state.buffers.next();
Review comment:
yea, I think it might make the caller (channelInactive or others if any)
thinks everything is fine inside `connectionTerminated`. Maybe not big deal for
now, but sounds a potential concern.
We might have multiple exception during releasing buffers. We can rethrow a
`RuntimeException` if any exception happens during releasing buffers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
