maropu commented on a change in pull request #22038: [SPARK-25056][SQL] Unify the InConversion and BinaryComparison behavior URL: https://github.com/apache/spark/pull/22038#discussion_r364526957
########## File path: sql/core/src/test/resources/sql-tests/results/typeCoercion/native/inConversion.sql.out ########## @@ -69,7 +69,7 @@ true -- !query 8 SELECT cast(1 as tinyint) in (cast(1 as string)) FROM t -- !query 8 schema -struct<(CAST(CAST(1 AS TINYINT) AS STRING) IN (CAST(CAST(1 AS STRING) AS STRING))):boolean> +struct<(CAST(CAST(1 AS TINYINT) AS TINYINT) IN (CAST(CAST(1 AS STRING) AS TINYINT))):boolean> Review comment: But, since this is a behaviour change in the existing `in`, I think its worth updating the guide. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
