imback82 commented on a change in pull request #26921: [SPARK-30282][SQL]
Integrate V2 commands with UnresolvedV2Relation into new resolution framework
URL: https://github.com/apache/spark/pull/26921#discussion_r364554123
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -595,6 +602,11 @@ class ResolveSessionCatalog(
}
}
+ private def getTableIdentifier(resolved: ResolvedTable): TableIdentifier = {
Review comment:
This takes in `ResolveTable` instead of `Identifier` to be explicit that
identifier is already resolved. (which is different from `asTableIdentifier`
defined in `V2SessionCatalog.scala`. That's why I am also doing assert below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
