sddyljsx commented on a change in pull request #27135: [SPARK-30458][Web UI] 
The Executor Computing Time in Time Line of Stage Page is Wrong
URL: https://github.com/apache/spark/pull/27135#discussion_r364597689
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
 ##########
 @@ -288,10 +288,10 @@ private[ui] class StagePage(parent: StagesTab, store: 
AppStatusStore) extends We
 
         val executorOverhead = serializationTime + deserializationTime
         val executorRunTime = if (taskInfo.duration.isDefined) {
-          totalExecutionTime - executorOverhead - gettingResultTime
+          math.max(totalExecutionTime - executorOverhead - gettingResultTime - 
schedulerDelay, 0)
 
 Review comment:
   It is impossible.
   I write math.max(xxx, 0) here,  just be consistent with the calculation of 
the executorComputingTimeProportion 
   L297:
    val executorComputingTimeProportion =
             math.max(100 - schedulerDelayProportion - 
shuffleReadTimeProportion -
               shuffleWriteTimeProportion - serializationTimeProportion -
               deserializationTimeProportion - gettingResultTimeProportion, 0)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to