Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4610#discussion_r24720095
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -67,7 +67,6 @@ private[sql] class DefaultSource
case SaveMode.Append =>
sys.error(s"Append mode is not supported by
${this.getClass.getCanonicalName}")
case SaveMode.Overwrite =>
- fs.delete(filesystemPath, true)
--- End diff --
Why remove it? I think we can first get the file status (we also need to
handle FileNotFoundException). Then, we check if data already exists. For
overwrite, we delete it and if `delete` returns false and data does exist, we
throw an exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
