cloud-fan commented on issue #26847: [SPARK-30214][SQL] A new framework to resolve v2 commands URL: https://github.com/apache/spark/pull/26847#issuecomment-572581704 The COMMENT ON only takes about 60 LOC except for tests, it doesn't make my review harder at least. This framework was blocking many things. Now we have several commits/open PRs depending on it: https://github.com/apache/spark/commit/314e70fe23a0ac80bc3060e11b56c884c660cc16 https://github.com/apache/spark/commit/b2ed6d0b880018e4eef5a225d6619cac4f4d6d63 https://github.com/apache/spark/pull/26921 https://github.com/apache/spark/pull/26775 I don't think it's realistic to revert it now. In general, we should separate PR into smaller ones, but there are always exceptions, e.g. https://github.com/apache/spark/pull/24798#issuecomment-511937029 If you have different ideas about the framework, please leave comments here, and we'll address them in followups.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
