cloud-fan commented on a change in pull request #26913: [SPARK-29219][SQL]
Introduce SupportsCatalogOptions for TableProvider
URL: https://github.com/apache/spark/pull/26913#discussion_r364774857
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -623,6 +656,30 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
CreateTable(tableDesc, mode, Some(df.logicalPlan)))
}
+ /** Converts the provided partitioning and bucketing information to
DataSourceV2 Transforms. */
+ private def partitioningAsV2: Seq[Transform] = {
+ val partitioning = partitioningColumns.map { colNames =>
+ colNames.map(name => IdentityTransform(FieldReference(name)))
+ }.getOrElse(Seq.empty[Transform])
+ val bucketing = bucketColumnNames.map { cols =>
Review comment:
shall we call `CatalogV2Implicits.BucketSpecHelper.asTransform`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
