gengliangwang commented on a change in pull request #27112: [SPARK-30428][SQL] File source V2: support partition pruning URL: https://github.com/apache/spark/pull/27112#discussion_r364902076
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScan.scala ########## @@ -71,7 +103,7 @@ abstract class FileScan( } protected def partitions: Seq[FilePartition] = { - val selectedPartitions = fileIndex.listFiles(Seq.empty, Seq.empty) + val selectedPartitions = fileIndex.listFiles(partitionFilters, Seq.empty) Review comment: Yes, it makes sense if there is a `fileIndex` can use the `dataFilters`. @guykhazma could you create a PR for this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org