Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24720203
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala
---
@@ -88,12 +88,24 @@ private[sql] class DataFrameImpl protected[sql](
}
}
- protected[sql] def numericColumns: Seq[Expression] = {
- schema.fields.filter(_.dataType.isInstanceOf[NumericType]).map { n =>
- queryExecution.analyzed.resolve(n.name,
sqlContext.analyzer.resolver).get
+ protected[sql] def numericColumns(colNames: String*): Seq[Expression] = {
+ val allNumbericCols =
schema.fields.filter(_.dataType.isInstanceOf[NumericType]).map(_.name)
+ val diff = colNames.diff(allNumbericCols)
+ if (diff.nonEmpty) {
--- End diff --
i think an easier way is to just traverse colNames, and throw an exception
if it is a not a numeric column. Really no need to be so complicated to get the
diff ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
