holdenk commented on a change in pull request #26440:
[WIP][SPARK-20628][CORE][K8S] Start to improve Spark decommissioning &
preemption support
URL: https://github.com/apache/spark/pull/26440#discussion_r364989417
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
##########
@@ -192,6 +193,21 @@ private[spark] class BasicExecutorFeatureStep(
.endResources()
.build()
}.getOrElse(executorContainer)
+ val containerWithLifecycle = kubernetesConf.workerDecommissioning match {
+ case false =>
+ logInfo("Decommissioning not enabled, skipping shutdown script")
+ containerWithLimitCores
+ case true =>
+ logInfo("Adding decommission script to lifecycle")
+ new ContainerBuilder(containerWithLimitCores).withNewLifecycle()
+ .withNewPreStop()
Review comment:
I'm not sure why it would not, all the other properties presumably work. Am
I missing some special handling logic we have seperate for the pods for dynamic
alloc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
