maropu commented on a change in pull request #27119: [SPARK-30447][SQL]
Constant propagation nullability issue
URL: https://github.com/apache/spark/pull/27119#discussion_r365000866
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -92,22 +92,32 @@ object ConstantPropagation extends Rule[LogicalPlan] with
PredicateHelper {
* - Otherwise, stop traversal and propagate empty mapping.
* @param condition condition to be traversed
* @param replaceChildren whether to replace attributes with constant values
in children
+ * @param nullIsFalse whether a boolean expression result can be considered
to false e.g. in the
+ * case of `WHERE e`, null result of expression `e` means the same as
if it resulted false
Review comment:
nit: indent
```
* @param nullIsFalse whether a boolean expression result can be
considered to false e.g. in the
* case of `WHERE e`, null result of expression `e`
means the same as if it resulted false
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
