holdenk commented on a change in pull request #26440: [SPARK-20628][CORE][K8S]
Start to improve Spark decommissioning & preemption support
URL: https://github.com/apache/spark/pull/26440#discussion_r365001624
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
##########
@@ -192,6 +193,21 @@ private[spark] class BasicExecutorFeatureStep(
.endResources()
.build()
}.getOrElse(executorContainer)
+ val containerWithLifecycle = kubernetesConf.workerDecommissioning match {
+ case false =>
+ logInfo("Decommissioning not enabled, skipping shutdown script")
+ containerWithLimitCores
+ case true =>
+ logInfo("Adding decommission script to lifecycle")
+ new ContainerBuilder(containerWithLimitCores).withNewLifecycle()
+ .withNewPreStop()
Review comment:
Oh I think I see where this is going. So (for right now) when Spark is doing
it's own internal down scaling we don't take advantage of that knowledge. We
totally should in the future, that's actually my plan in part 5 but I wanted to
keep the scope as small as possible for the first change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
