Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4612#discussion_r24721876
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala
 ---
    @@ -74,10 +74,12 @@ class FileInputDStream[K, V, F <: NewInputFormat[K,V]](
         directory: String,
         filter: Path => Boolean = FileInputDStream.defaultFilter,
         newFilesOnly: Boolean = true,
    -    conf: Option[Configuration] = None)
    +    @transient conf: Option[Configuration] = None)
    --- End diff --
    
    I've always disliked using `@transient` for this kind of thing ... can it 
just be a constructor param, that is only used to construct 
`serializableConfOpt`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to