beliefer commented on issue #27058: [SPARK-30395][SQL] When one or more DISTINCT aggregate expressions operate on the same field, the DISTINCT aggregate expression allows the use of the FILTER clause URL: https://github.com/apache/spark/pull/27058#issuecomment-572999709 > Yea, I know that. What I just want to know is that we need a lot of code changes to support the thrid case (SPARK-30396 )? ISTM we can easily extend this approache (expland w/ filters in the first aggregation phase) for supporting that. If so, I think its ok to merge the two work in this single PR. Any techinical barrir to do so? When there exists multi DISTINCT aggregate exprs. If each aggregate function acting on the same columns, the code path is different from aggregate function acting on different columns. The implement will have some different. Seperate the implement into different PR will be easy to review.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
