srowen commented on a change in pull request #27160: [SPARK-30478][Core]Update
the Doc of Memory Package
URL: https://github.com/apache/spark/pull/27160#discussion_r365251389
##########
File path: core/src/main/scala/org/apache/spark/memory/package.scala
##########
@@ -40,25 +40,26 @@ package org.apache.spark
*
* Diagrammatically:
*
- * {{{
- * +-------------+
- * | MemConsumer |----+
+------------------------+
- * +-------------+ | +-------------------+ |
MemoryManager |
- * +--->| TaskMemoryManager |----+ |
|
- * +-------------+ | +-------------------+ | |
+------------------+ |
- * | MemConsumer |----+ | | |
StorageMemPool | |
- * +-------------+ +-------------------+ | |
+------------------+ |
- * | TaskMemoryManager |----+ |
|
- * +-------------------+ | |
+------------------+ |
- * +---->|
|OnHeapExecMemPool | |
- * * | |
+------------------+ |
- * * | |
|
- * +-------------+ * | |
+------------------+ |
- * | MemConsumer |----+ | |
|OffHeapExecMemPool| |
- * +-------------+ | +-------------------+ | |
+------------------+ |
- * +--->| TaskMemoryManager |----+ |
|
- * +-------------------+
+------------------------+
- * }}}
+ * {{{
+---------------------------+
+ * +-------------+ |
MemoryManager |
+ * | MemConsumer |----+ |
|
+ * +-------------+ | +-------------------+ |
+---------------------+ |
+ * +--->| TaskMemoryManager |----+ |
|OnHeapStorageMemPool | |
+ * +-------------+ | +-------------------+ | |
+---------------------+ |
+ * | MemConsumer |----+ | |
|
+ * +-------------+ +-------------------+ | |
+---------------------+ |
+ * | TaskMemoryManager |----+ |
|OffHeapStorageMemPool| |
+ * +-------------------+ | |
+---------------------+ |
+ * +---->|
|
+ * * | |
+---------------------+ |
+ * * | |
|OnHeapExecMemPool | |
+ * +-------------+ * | |
+---------------------+ |
+ * | MemConsumer |----+ | |
|
+ * +-------------+ | +-------------------+ | |
+---------------------+ |
+ * +--->| TaskMemoryManager |----+ |
|OffHeapExecMemPool | |
+ * +-------------------+ |
+---------------------+ |
+ * |
|
+ * }}}
+---------------------------+
Review comment:
I think the open and close braces have to be on their own lines. Here, the
last part of the table is outside the block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
