srowen commented on a change in pull request #27135: [SPARK-30458][Web UI] Fix
Wrong Executor Computing Time in Time Line of Stage Page
URL: https://github.com/apache/spark/pull/27135#discussion_r365334011
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
##########
@@ -288,10 +288,10 @@ private[ui] class StagePage(parent: StagesTab, store:
AppStatusStore) extends We
val executorOverhead = serializationTime + deserializationTime
val executorRunTime = if (taskInfo.duration.isDefined) {
- totalExecutionTime - executorOverhead - gettingResultTime
+ math.max(totalExecutionTime - executorOverhead - gettingResultTime -
schedulerDelay, 0)
Review comment:
I think it's fine for consistency and perhaps to account for rounding errors
or something. I'm OK with it as the current calculation does seem obviously
wrong in at least one case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
