yuchenhuo commented on a change in pull request #26957: [WIP][SPARK-30314] Add identifier and catalog information to DataSourceV2Relation URL: https://github.com/apache/spark/pull/26957#discussion_r365403033
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala ########## @@ -44,15 +44,27 @@ class CatalogManager( import CatalogManager.SESSION_CATALOG_NAME private val catalogs = mutable.HashMap.empty[String, CatalogPlugin] + // Map from catalog back to it's original name for easy name look up, we don't use the + // CatalogPlugin's name as it might be different from the catalog name depending on + // implementation. + private val catalogIdentifiers = mutable.HashMap.empty[CatalogPlugin, String] Review comment: Do we need to handle `v1SessionCatalog` passed by the constructor here too? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
