Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/4563#issuecomment-74471070
Removed the `withSQLConf` trick in test suites like `ParquetQuerySuite`. A
simplified version of the problem can be shown as:
```scala
withSQLConf(SQLConf.PARQUET_USE_DATA_SOURCE_API -> "false") {
test("some test") {
...
}
}
```
The execution order of this snippet is:
1. `SQLConf.PARQUET_USE_DATA_SOURCE_API` is set to `false`
2. A ScalaTest test case "some test" is created
3. `SQLConf.PARQUET_USE_DATA_SOURCE_API` is reverted (removed)
4. ScalaTest starts executing test case "some test"
5. "some test" executes with the default value of
`SQLConf.PARQUET_USE_DATA_SOURCE_API` configuration, which is `true`
In the last commit, I removed the `withSQLConf` trick and fall back to
`beforeAll`/`afterAll`. This introduced hundreds of lines of indentation
changes in several test suites, thus made this PR twice as large.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
