HyukjinKwon opened a new pull request #27182: 
[SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll 
properly via Rouge
URL: https://github.com/apache/spark/pull/27182
 
 
   ### What changes were proposed in this pull request?
   
   This PR proposes to use Pygment compatible format by Rouge. As of 
https://github.com/apache/spark/pull/26521, we use Rouge instead of Pygment 
wrapper in Ruby.
   Rouge claims Pygment compatibility; and we should output as Pygment does.
   
   ```ruby
   Rouge::Formatters::HTMLPygments.new(formatter)
   ```
   
   wraps codes with `<div class="highlight"><pre>...` properly.
   
   ### Why are the changes needed?
   
   To keep the documentation pretty and not broken.
   
   ### Does this PR introduce any user-facing change?
   
   Theoretically, no. This is rather a regression fix in documentation. See the 
regression in the doc - 
https://spark.apache.org/docs/3.0.0-preview2/sql-pyspark-pandas-with-arrow.html
   
   ### How was this patch tested?
   
   Manually built the doc.
   
   **Before:**
   ![Screen Shot 2020-01-13 at 10 21 28 
AM](https://user-images.githubusercontent.com/6477701/72229159-ba766a80-35ef-11ea-9a5d-9583448e7c1c.png)
   
   **After:**
   
   ![Screen Shot 2020-01-13 at 10 26 33 
AM](https://user-images.githubusercontent.com/6477701/72229157-b34f5c80-35ef-11ea-8b3a-492e8aa0f82a.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to