HyukjinKwon opened a new pull request #27186: [SPARK-30480][PYTHON][TESTS] 
Increases the memory limit being tested in 'WorkerMemoryTest.test_memory_limit'
URL: https://github.com/apache/spark/pull/27186
 
 
   ### What changes were proposed in this pull request?
   
   This PR proposes to increase the memory in 
`WorkerMemoryTest.test_memory_limit` in order to make the test pass with PyPy.
   
   The test is currently failed only in PyPy as below:
   
   ```
   Current mem limits: 18446744073709551615 of max 18446744073709551615
   
   Setting mem limits to 1048576 of max 1048576
   
   RPython traceback:
     File "pypy_module_pypyjit_interp_jit.c", line 289, in portal_5
     File "pypy_interpreter_pyopcode.c", line 3468, in 
handle_bytecode__AccessDirect_None
     File "pypy_interpreter_pyopcode.c", line 5558, in 
dispatch_bytecode__AccessDirect_None
   out of memory: couldn't allocate the next arena
   ERROR
   ```
   
   It seems related to how PyPy allocates the memory and GC works 
PyPy-specifically. There seems nothing wrong in this configuration 
implementation itself in PySpark side.
   
   I roughly tested in higher PyPy versions on Ubuntu and this test seems 
passing fine so I suspect this might be an issue in old PyPy behaviours.
   
   The change only increases the limit so it would not affect actual memory 
allocations. It just needs to test if the limit is properly set in worker 
sides. For clarification, this limit is maximum memory in the machine if not 
set. 
   
   ### Why are the changes needed?
   
   To make the tests pass and unblock other PRs.
   
   ### Does this PR introduce any user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Manually and Jenkins should test it out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to