Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4626#discussion_r24772103
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
    @@ -163,7 +163,14 @@ private[hive] class HiveMetastoreCatalog(hive: 
HiveContext) extends Catalog with
         val table = client.getTable(databaseName, tblName)
     
         if (table.getProperty("spark.sql.sources.provider") != null) {
    -      cachedDataSourceTables(QualifiedTableName(databaseName, 
tblName).toLowerCase)
    +      val datasourceTable =
    +        cachedDataSourceTables(QualifiedTableName(databaseName, 
tblName).toLowerCase)
    +      // Wrap the table with a Subquery with the table name.
    +      val tableWithQualifers = Subquery(tableIdent.last, datasourceTable)
    +      // Then, if alias is specified, wrap the table again with the alias 
in a Subquery.
    +      val withAlias = alias.map(a => Subquery(a, 
tableWithQualifers)).getOrElse(tableWithQualifers)
    --- End diff --
    
    Nit: the double subquery here does nothing.  I'd just use `dataSourceTable` 
in the `.map(...)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to