Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/186#issuecomment-41202781
@CodingCat @markhamstra I looked through this and the approach seems fine,
but one scary thing is that some of the code moved into `receive` doesn't match
the code deleted above, probably due to git rebases in-between. Please check
through it carefully and make it the same. To help with that I've also
suggested moving some of the event handlers that had a lot of code in there to
methods on DAGScheduler.
Because this is a pretty big change we should also test it fairly
thoroughly for multithreaded behavior, scheduling throughput, etc. It *seems*
okay in terms of threading in that everything was happening in the `receive`
method of the actor before too, but wouldn't hurt to run some stress tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
