huaxingao commented on a change in pull request #26232:
[SPARK-29093][PYTHON][ML] Remove automatically generated param setters in
_shared_params_code_gen.py
URL: https://github.com/apache/spark/pull/26232#discussion_r365929331
##########
File path: python/pyspark/ml/clustering.py
##########
@@ -873,6 +1049,31 @@ class LDAModel(JavaModel, _LDAParams):
.. versionadded:: 2.0.0
"""
+ @since("3.0.0")
+ def setFeaturesCol(self, value):
+ """
+ Sets the value of :py:attr:`featuresCol`.
+ """
+ return self._set(featuresCol=value)
+
+ @since("3.0.0")
+ def setSeed(self, value):
+ """
+ Sets the value of :py:attr:`seed`.
+ """
+ return self._set(seed=value)
+
+ @since("3.0.0")
+ def setTopicDistributionCol(self, value):
+ """
+ Sets the value of :py:attr:`topicDistributionCol`.
+
+ >>> algo = LDA().setTopicDistributionCol("topicDistributionCol")
Review comment:
No. Just fix the small things I overlooked before, for example, I have
setters in ```TrainValidationSplitModel/CrossValidatorModel``` because these
setters are used in ```_from_java```. I will remove the setters and use _set
instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
