Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/2851#issuecomment-74583601
Potential problems in the current patch
1. to de-duplicate the code in StorageUtils, I save RDD ID with **Int**
type in a **Long** Field
(https://github.com/apache/spark/pull/2851/files#diff-21027f5c826cd378daaae5f7c3eea2b5R41),
otherwise it's hard to get a BlockMap according to the blockId
(https://github.com/apache/spark/pull/2851/files#diff-21027f5c826cd378daaae5f7c3eea2b5R126)
(you will see a lot of type imcompatibility from the compiler)
2. InMemoryObjectPage.scala
(https://github.com/apache/spark/pull/2851/files#diff-dc63d4ab5b2ed5a2135c054be78820eeR97),
I'm not sure if the semantics of (memory usage of a worker) is correct...it
should be the memory used by the current InMemoryObject or the total memory
usage?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
