MaxGekk commented on a change in pull request #27200: [SPARK-30509][SQL] Fix
deprecation log warning in Avro schema inferring
URL: https://github.com/apache/spark/pull/27200#discussion_r366271863
##########
File path:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -1497,6 +1497,32 @@ abstract class AvroSuite extends QueryTest with
SharedSparkSession {
|}
""".stripMargin)
}
+
+ test("log a warning of ignoreExtension deprecation") {
+ val logAppender = new LogAppender
+ withTempPath { dir =>
+ Seq(("a", 1, 2), ("b", 1, 2), ("c", 2, 1), ("d", 2, 1))
+ .toDF("value", "p1", "p2")
+ .repartition(2)
+ .write
+ .format("avro")
+ .option("header", true)
+ .save(dir.getCanonicalPath)
+ withLogAppender(logAppender) {
+ spark
+ .read
+ .format("avro")
+ .option(AvroOptions.ignoreExtensionKey, false)
+ .option("header", true)
+ .load(dir.getCanonicalPath)
+ .count()
+ }
+ val deprecatedEvents = logAppender.loggingEvents
+ .filter(_.getRenderedMessage.contains(
+ s"Option ${AvroOptions.ignoreExtensionKey} is deprecated"))
+ assert(deprecatedEvents.size === 1)
Review comment:
So, if somebody modifies the code in the future in the way the warning is
printed many times, we will catch the situation by the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
