cloud-fan commented on a change in pull request #27197: [SPARK-30507][SQL]
TableCalalog reserved properties shoudn't be changed via options or tblpropeties
URL: https://github.com/apache/spark/pull/27197#discussion_r366371314
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2669,6 +2670,41 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
ctx.EXTENDED != null)
}
+ private def cleanTableProperties(
+ properties: Map[String, String],
+ location: Option[String],
+ isOptionClause: Boolean,
+ ctx: ParserRuleContext): Map[String, String] = withOrigin(ctx) {
+ import org.apache.spark.sql.connector.catalog.TableCatalog._
+ val legacyOn = conf.getConf(SQLConf.LEGACY_PROPERTY_NON_RESERVED)
+ var pathDefined = false
+ properties.filter {
Review comment:
can we update `cleanNamespaceProperties` to use filter as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
