dongjoon-hyun commented on a change in pull request #27178: [SPARK-30491][INFRA][2.4] Enable dependency audit files to tell dependency classifier URL: https://github.com/apache/spark/pull/27178#discussion_r366669428
########## File path: dev/deps/spark-deps-hadoop-2.6 ########## @@ -153,8 +153,8 @@ objenesis/2.5.1/objenesis-2.5.1.jar okhttp/3.12.0/okhttp-3.12.0.jar okio/1.15.0/okio-1.15.0.jar opencsv/2.3/opencsv-2.3.jar -orc-core/1.5.5/orc-core-1.5.5-nohive.jar -orc-mapreduce/1.5.5/orc-mapreduce-1.5.5-nohive.jar +orc-core/1.5.5/nohive/orc-core-1.5.5-nohive.jar +orc-mapreduce/1.5.5/nohive/orc-mapreduce-1.5.5-nohive.jar Review comment: This is good and can we have four field always for the other jars which doesn't have classifiers? Something like the following? ``` - orc-shims/1.5.5/orc-shims-1.5.5.jar + orc-shims/1.5.5//orc-shims-1.5.5.jar ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
