viirya commented on a change in pull request #26682: [SPARK-29306][CORE] Stage
Level Sched: Executors need to track what ResourceProfile they are created with
URL: https://github.com/apache/spark/pull/26682#discussion_r366713990
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##########
@@ -272,11 +272,16 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
removeWorker(workerId, host, message)
context.reply(true)
- case RetrieveSparkAppConfig =>
+ case RetrieveSparkAppConfig(resourceProfileId) =>
+ // note this will be updated in later prs to get the ResourceProfile
from a
+ // ResourceProfileManager that matches the resource profile id
+ // for now just use default profile
+ val rp = ResourceProfile.getOrCreateDefaultProfile(conf)
val reply = SparkAppConfig(
sparkProperties,
SparkEnv.get.securityManager.getIOEncryptionKey(),
- Option(delegationTokens.get()))
+ Option(delegationTokens.get()),
+ rp)
Review comment:
Executors do not know what default ResourceProfile is? If default
ResourceProfile is derived from Spark configs, do we still need to send a
default ResourceProfile to executors? Can executors generate it if it knows it
uses default one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
