gengliangwang commented on a change in pull request #27212: [SPARK-30515][SQL]
Refactor SimplifyBinaryComparison to reduce the time complexity
URL: https://github.com/apache/spark/pull/27212#discussion_r366717109
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -410,37 +410,41 @@ object SimplifyBinaryComparison
extends Rule[LogicalPlan] with PredicateHelper with ConstraintHelper {
private def canSimplifyComparison(
- plan: LogicalPlan, left: Expression, right: Expression): Boolean = {
+ left: Expression,
+ right: Expression,
+ getNotNullExpressions: () => ExpressionSet): Boolean = {
Review comment:
Got it, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
