cloud-fan commented on a change in pull request #26961: [SPARK-29708][SQL]
Correct aggregated values when grouping sets are duplicated
URL: https://github.com/apache/spark/pull/26961#discussion_r366733463
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -641,11 +640,14 @@ object Expand {
child: LogicalPlan): Expand = {
val attrMap = groupByAttrs.zipWithIndex.toMap
+ val hasDuplicateGroupingSets = groupingSetsAttrs.size !=
+ groupingSetsAttrs.map(_.map(_.canonicalized).toSet).distinct.size
Review comment:
so `(k1,k2),(k2,k1)` are also duplicated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
