cloud-fan commented on a change in pull request #27197: [SPARK-30507][SQL]
TableCalalog reserved properties shoudn't be changed via options or tblpropeties
URL: https://github.com/apache/spark/pull/27197#discussion_r366871367
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2360,7 +2360,8 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
operationNotAllowed(
s"Values should not be specified for key(s): ${badKeys.mkString("[",
",", "]")}", ctx)
}
- props.keys.toSeq
+ val cleanedTableProperties = cleanTableProperties(ctx, props)
Review comment:
why we need to clean here but not `visitPropertyKeyValues`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
