Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4562#discussion_r24791802
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala ---
    @@ -287,7 +287,11 @@ case class ParquetRelation2(
             }
           }
     
    -      parquetSchema = maybeSchema.getOrElse(readSchema())
    +      try {
    +        parquetSchema = readSchema().getOrElse(maybeSchema.get)
    +      } catch {
    +        case e => throw new SparkException(s"Failed to find schema for 
${paths.mkString(",")}", e)
    +      }
    --- End diff --
    
    How about this 
    ```
    parquetSchema = {
      if (maybeSchema.isDefined) {
        maybeSchema.get
      } else {
        (readSchema(), maybeMetastoreSchema) match {
          case (Some(dataSchema), _) => dataSchema
          case (None, Some(metastoreSchema)) => metastoreSchema
          case (None, None) =>
            throw new SparkException("Failed to get the schema.")
         }
      }
    }
    ```
    We first check if maybeSchema is defined. If not, we read the schema from 
existing data. If existing data does not exist, we are dealing with a newly 
created empty table and we will use maybeMetastoreSchema defined in the options.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to