dongjoon-hyun commented on a change in pull request #27198:
[SPARK-27986][SQL][FOLLOWUP] Respect filter in sql/toString of
AggregateExpression
URL: https://github.com/apache/spark/pull/27198#discussion_r367078529
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
##########
@@ -149,10 +150,20 @@ case class AggregateExpression(
case PartialMerge => "merge_"
case Final | Complete => ""
}
- prefix + aggregateFunction.toAggString(isDistinct)
+ val aggFuncStr = prefix + aggregateFunction.toAggString(isDistinct)
+ filter match {
+ case Some(predicate) => s"$aggFuncStr filter (where $predicate)"
Review comment:
If you don't mind, `filter (where` -> `FILTER (WHERE`?
Currently, in the generated result, `filter (where NOT` and `FILTER (WHERE
(NOT` are used together. Maybe, the same output might be better?
> sum(salary#x) filter (where NOT exists#x [dept_id#x]) AS sum(salary)
FILTER (WHERE (NOT exists(dept_id)))#x]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
