vanzin commented on a change in pull request #27208: [SPARK-30481][CORE]
Integrate event log compactor into Spark History Server
URL: https://github.com/apache/spark/pull/27208#discussion_r367142717
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -661,26 +691,33 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
reader: EventLogFileReader,
scanTime: Long,
enableOptimizations: Boolean): Unit = {
+ val rootPath = reader.rootPath
try {
+ val (shouldReload, lastCompactionIndex) = compact(reader)
Review comment:
Is there anyway to do compaction as a separate task? Otherwise it seems like
this could slow down the creation of the app listing, especially if you're not
using disk caching or it's the first time the SHS is creating the listing db.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
