gatorsmile commented on a change in pull request #27184:
[SPARK-28152][SQL][FOLLOWUP] Add a legacy conf for old MsSqlServerDialect
numeric mapping
URL: https://github.com/apache/spark/pull/27184#discussion_r367183462
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2161,6 +2161,13 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val LEGACY_MSSQLSERVER_NUMERIC_MAPPING_ENABLED =
+ buildConf("spark.sql.legacy.mssqlserver.numericMapping.enabled")
+ .internal()
+ .doc("When true, use legacy MySqlServer SMALLINT and REAL type mapping.")
Review comment:
It is not very clear what is the legacy MySqlServer SMALLINT and REAL type
mapping if they do not read the PR. Could we make it clear? The behavior when
the value is set to true and the behavior when the value is false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
