HyukjinKwon edited a comment on issue #26875: [SPARK-30245][SQL] Add cache for 
Like and RLike when pattern is not static
URL: https://github.com/apache/spark/pull/26875#issuecomment-574934642
 
 
   @ulysses-you, I heard some concerns about this PR when the strings are very 
large. String.equals vs pattern complication. So, some people worry about the 
regressions for large strings.
   
   Do you mind if I ask to run some benchmarks for larger strings too? It would 
be nice if we make sure  consecutive rows should have different, long strings, 
to gauge what kind of regression we’re going to get in a worst case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to